Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-819]:Create issue modal crashes when assignee is selected before switching projects #879

Merged
merged 7 commits into from
Feb 25, 2023
Merged

[GH-819]:Create issue modal crashes when assignee is selected before switching projects #879

merged 7 commits into from
Feb 25, 2023

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Oct 19, 2022 •
edited
Loading

Summary

  • Create issue modal was crashing when the assignee is selected before switching projects.
  • This PR contains all the changes from Pr #834 So this PR alone is enough to fix this issue so we can close Pr #834 afterward.

Issue

@Kshitij-Katiyar @maisnamrajusingh
[MI-2228]:Fixed Jira Issue 819 (Create issue modal crashes when assig…
a9a15ab 
…nee is selected before switching projects) (#8)

* iterim pr for qa

* updated changes that fixes crash

* this is a hotfix that fixes the crash

* fixes line issue

* updated logic to reset fields

* spacing

* updated types for datatypes

* fixed linting

* fixed linting issues

* [MI-2228]:Fixed jira issue 819

* [MI-2228]:Fixed review fixes

Co-authored-by: raju <raju.s@demansol.com>
Co-authored-by: sibasankarnayak <sibasankar@demansoltech.com>
@mattermod
Copy link
Contributor

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Codecov Report

Base: 31.27% // Head: 31.27% // No change to project coverage 👍

Coverage data is based on head (efceb99) compared to base (a6aa3fe).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   31.27%   31.27%           
=======================================
  Files          49       49           
  Lines        6017     6017           
=======================================
  Hits         1882     1882           
  Misses       3946     3946           
  Partials      189      189

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

javaguirre
javaguirre approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@javaguirre javaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei added Awaiting Submitter Action Blocked on the author 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 29, 2022
@hanzei hanzei linked an issue Nov 29, 2022 that may be closed by this pull request
Create issue modal crashes when assignee is selected before switching projects #819
Closed
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei added this to the v3.3.0 milestone Feb 21, 2023
@hanzei
Copy link
Collaborator

hanzei commented Feb 21, 2023

@DHaussermann Gentle reminder to review the PR

DHaussermann
DHaussermann approved these changes Feb 24, 2023
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • The issue is resolved
  • Exploratory testing around create modal found no regressions or other issues
  • The case was not applicable to swapping instances as projects are loaded in when new instance is selected

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Feb 24, 2023
@hanzei hanzei merged commit ba4e351 into mattermost:master Feb 25, 2023
@mickmister mickmister mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javaguirre javaguirre javaguirre approved these changes

@mickmister mickmister mickmister approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
next milestone
Development

Successfully merging this pull request may close these issues.

Create issue modal crashes when assignee is selected before switching projects
8 participants
@Kshitij-Katiyar @mattermod @codecov-commenter @mattermost-build @hanzei @javaguirre @mickmister @DHaussermann